Update PathTraversalVulnerability.java#471
Open
tidaaartorhem wants to merge 1 commit intoSasanLabs:masterfrom
Open
Update PathTraversalVulnerability.java#471tidaaartorhem wants to merge 1 commit intoSasanLabs:masterfrom
tidaaartorhem wants to merge 1 commit intoSasanLabs:masterfrom
Conversation
Key Changes Explained: Enhanced security checks: Added checks to prevent Path Traversal attacks by verifying that the file name does not contain ".." and is within the list of allowed file names. Improved error handling: Changed the HTTP response codes to more accurately reflect the nature of the error (e.g., returning 404 Not Found for missing files and 403 Forbidden for unauthorized access attempts). Condition validation: Immediately returns a 400 Bad Request if the precondition is not met, which helps in quickly identifying issues with request parameters. Error Logging: Now logs different types of errors distinctly for better diagnostics.Key Changes Explained: Enhanced security checks: Added checks to prevent Path Traversal attacks by verifying that the file name does not contain ".." and is within the list of allowed file names. Improved error handling: Changed the HTTP response codes to more accurately reflect the nature of the error (e.g., returning 404 Not Found for missing files and 403 Forbidden for unauthorized access attempts). Condition validation: Immediately returns a 400 Bad Request if the precondition is not met, which helps in quickly identifying issues with request parameters. Error Logging: Now logs different types of errors distinctly for better diagnostics.
preetkaran20
reviewed
May 1, 2024
| } | ||
|
|
||
| // Preventing Path Traversal and ensuring only allowed filenames are processed. | ||
| if (fileName.contains("..") || !ALLOWED_FILE_NAMES.contains(fileName)) { |
Member
There was a problem hiding this comment.
Why this change? we wanted to introduce vulnerability in the application and this will disallow ".." in file name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes Explained:
Enhanced security checks: Added checks to prevent Path Traversal attacks by verifying that the file name does not contain ".." and is within the list of allowed file names.
Improved error handling: Changed the HTTP response codes to more accurately reflect the nature of the error (e.g., returning 404 Not Found for missing files and 403 Forbidden for unauthorized access attempts).
Condition validation: Immediately returns a 400 Bad Request if the precondition is not met, which helps in quickly identifying issues with request parameters.
Error Logging: Now logs different types of errors distinctly for better diagnostics.