This repository was archived by the owner on Jun 24, 2019. It is now read-only.
Add Login Component#10
Open
Rapdorian wants to merge 5 commits intoSamDelaney:masterfrom
Rapdorian:master
Open
Conversation
Owner
|
Needs Unit Tests |
tyasw
reviewed
Jun 4, 2019
| import Input from "@material-ui/core/Input"; | ||
| import { Grid } from "@material-ui/core"; | ||
| import { asyncLogin, asyncRegister } from "./LoginActions"; | ||
|
|
Collaborator
There was a problem hiding this comment.
Some of these imports are unused.
Collaborator
|
You have a root-level src/ directory, but the src/ directory is inside of thecombine/ on master. I'm not sure if that's fixed on the new repository or not. Otherwise, both the register and submit buttons are called. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.