Open
Conversation
- Created core files including package.json, README.md, and TypeScript configuration. - Implemented voice recording functionality with hooks and components. - Added visual waveform representation and playback controls. - Included TypeScript support and defined project structure. - Added .gitignore to exclude unnecessary files and directories.
- Revised description for clarity and conciseness. - Added new properties (width, height, style) to VoiceRecorderProps for customization. - Expanded the UseVoiceRecorderReturn type with a new 'restart' method. - Introduced a time formatting function for better time display in the UI. - Updated the example UI to include the restart functionality and improved button layout. - Added a new features section to highlight capabilities of the voice recorder.
- Updated DeleteIcon SVG for improved visual representation. - Introduced a new types.ts file to define RecorderState and options for the voice recorder. - Refactored useVoiceRecorder hook to include new state management and methods for handling recording, pausing, and stopping. - Enhanced VoiceRecorder component to utilize updated state and methods, improving user interaction and control. - Consolidated type exports in index.ts for better organization.
- Added ResumeIcon to the icon set for improved user experience. - Expanded VoiceRecorderProps to include additional styling options such as backgroundColor, borderColor, and button customization. - Updated the VoiceRecorder component to utilize new props for better visual customization and user interaction. - Refactored visualizer bar properties for dynamic styling based on props. - Improved button hover effects and icon rendering for enhanced usability.
- Revised project description for better readability. - Enhanced VoiceRecorderProps section with clearer property descriptions and added styling options. - Updated usage examples to reflect new features and improved component API. - Added detailed recording states to clarify component behavior. - Improved overall structure and formatting for better navigation.
…rding states - Introduced a new section in README.md to showcase various states of the voice recorder. - Added images for initial state, recording in progress, paused state, and completed recording. - Enhanced documentation to improve user understanding of the component's functionality.
…ved discoverability
9 tasks
Collaborator
|
Why do we need a dependency for this? can't we just use MediaRecorder api directly? also I personally don't like the UI, it doesn't fit sable. also would this work on safari and ios? it defaults to I rather avoid external dependencies for simple things. Gives us more control as well |
Member
|
Safari and iOS have supported webm playback for years now. I do agree the theming doesn’t fit in too well. |
Collaborator
I think ogg would be a better fit for audio files. https://caniuse.com/ogg-vorbis |
ignored files: .lh
Contributor
Author
|
probably using this adjusted to our needs fork then: https://github.com/dozro/sable-voice-recorder-kit |
Collaborator
|
can you integrate it within the codebase as a feature? tracking dependencies is pain and from what I can tell its just web apis and react, so no external dependencies. |
…-into-sable' into feat/audio-recordings
ignored files: .lh
Contributor
Author
|
screenshots from mobile: 
TO-DO: streamline it more for mobile phone usage on desktop: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adding functionality to compose voice messages
Fixes #3
Type of change
Checklist: