Skip to content

[Add] create and delete a ParameterSubscription from the Model Editor; fixes #779#782

Merged
samatstariongroup merged 1 commit into
developmentfrom
GH779-create-parameter-subsscription
May 4, 2026
Merged

[Add] create and delete a ParameterSubscription from the Model Editor; fixes #779#782
samatstariongroup merged 1 commit into
developmentfrom
GH779-create-parameter-subsscription

Conversation

@samatstariongroup
Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

  • New subscribe button on each parameter card in the Model Editor whose owner is a different DomainOfExpertise than the current one; opens a confirm popup and creates a ParameterSubscription (with one ParameterSubscriptionValueSet per source ParameterValueSet) for the current domain.
  • New unsubscribe button on cards where the current domain already has a subscription; opens a confirm popup and deletes only the ParameterSubscription — the parent Parameter is preserved.
  • Card refresh after either action relies on the existing OnEndUpdateOnSessionRefreshedSelectElement message-bus chain (no manual row mutation), so the card automatically rebuilds with the post-server state — including subscription-aware ActualValue from the matching ParameterSubscriptionValueSet.

layout is sub-optimal, we'll redesign the page in a separate issue and PR

@samatstariongroup samatstariongroup requested a review from joao4all May 4, 2026 15:39
@samatstariongroup samatstariongroup merged commit 68dc695 into development May 4, 2026
10 checks passed
@samatstariongroup samatstariongroup deleted the GH779-create-parameter-subsscription branch May 8, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants