[Add] self-service "Edit my profile" in the Session menu; fixes #722#776
Merged
Conversation
83c4205 to
cc89d01
Compare
antoineatstariongroup
approved these changes
May 4, 2026
joao4all
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Adds an Edit my profile entry to the Session dropdown that opens a tabbed popup populated from
Session.ActivePerson:Save goes through the existing
ISessionService.CreateOrUpdateThingsWithNotificationpipeline, so success/error toasts and the SDK write path are reused. Admin-only fields (PersonRole, Organization, IsActive, IsDeprecated) are deliberately not surfaced.Implementation notes
PersonEditForm+PersonEditViewModel(and contact row VMs) live inCOMET.Web.Commonso the Session menu can reach them without inverting the project dependency into the adminUserManagementForm.ISessionMenuViewModelgainsIsOnEditPersonMode,PersonEditViewModel,OpenEditPersonPopup(), with auto-close on save.SessionMenu.razor(top-bar) andSessionSideBar.razor(sidebar — the variant the running app uses; inheritsSessionMenu's code but not its markup)..session__buttonsrestyled into two stacked groups separated by aborder-topso the profile action is visually grouped apart from Refresh / Log out.Risks
NotificationDescription.OnError. Auto-relogin is a follow-up.Test plan
dotnet build COMETwebapp.sln --no-restoredotnet test --filter "FullyQualifiedName!~IntegrationTests"— 652 / 652 passing baselinecdp4services-public.cdp4.org: open Edit my profile → edit name → Save → reopen and verify; add a second e-mail set as default → reopen and verify; change password (mismatch disables Save) → Save → success toast; Cancel performs no write.