[Add] feature to delete a parameter via the model editor#775
Merged
Conversation
joao4all
approved these changes
May 1, 2026
Contributor
joao4all
left a comment
joao4all
left a comment
There was a problem hiding this comment.
LGTM, small things concerning null values
|
|
||
| if (result.IsSuccess) | ||
| { | ||
| this.ElementDefinitionDetailsViewModel.Rows = this.SelectedElementDefinition?.Parameter |
Contributor
There was a problem hiding this comment.
In this case, if the SelectedElementDefinition is null, the rows from ElementDefinitionDetailsViewModel are null. Is it possible that we get a null exception from Rows being null?
| } | ||
| catch (Exception exception) | ||
| { | ||
| this.logger?.LogError(exception, "An error occurred while deleting the Parameter with iid {Iid}", parameter.Iid); |
Contributor
There was a problem hiding this comment.
Is there any case where logger is null? If not, pls remove the "?" here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
add a delete button the parameter cards in the model editor such that a user can delete a parameter. Confirmation is asked via a confirmation dialog