Skip to content

[Add] delete ElementUsage and ElementDefinition in Model Editor; fixes #771 and #772#773

Merged
samatstariongroup merged 1 commit into
developmentfrom
GH771-model-editor-delete-element-usage
May 1, 2026
Merged

[Add] delete ElementUsage and ElementDefinition in Model Editor; fixes #771 and #772#773
samatstariongroup merged 1 commit into
developmentfrom
GH771-model-editor-delete-element-usage

Conversation

@samatstariongroup
Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the COMET-WEB code style guidelines
  • I have provided test coverage for my change (where applicable)

Description

#771 — Web-app-friendly delete for ElementDefinition / ElementUsage

  • Danger-styled Delete button in the details-panel action header (visible only with selection; disabled with tooltip when the selected element is the iteration's
    TopElement).
  • Reuses ConfirmCancelPopup with a uniform message — no reference-count warning (server cascades cleanup of referencing usages).
  • ModelEditorViewModel exposes SelectedElement, IsSelectedElementTopElement, IsOnDeletionMode, DeleteElementPopupViewModel, OpenDeleteElementPopup,
    DeleteSelectedElementAsync. Delete clones container + thing, calls SessionService.DeleteThingsWithNotification, clears selection on success, and finally-closes the popup
    so a thrown exception can no longer leave the dialog open. ILogger injected for error logging.

@samatstariongroup samatstariongroup requested a review from joao4all May 1, 2026 15:24
@samatstariongroup samatstariongroup merged commit afe1404 into development May 1, 2026
8 checks passed
@samatstariongroup samatstariongroup deleted the GH771-model-editor-delete-element-usage branch May 1, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants