Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Consolidates the existing /profile and /user?author=<user> experiences into a single /user route, so the same page can render either a public user profile (by author) or the signed-in user’s own profile (including bookmarks).
Changes:
- Removes the
/profileroute and migrates its UI (bookmarks/profile header) intoapp/user/client-page.tsx. - Updates internal navigation to point to
/user(dropdown, “last updated by”, latest rules table). - Adjusts
/userpage metadata and server-side wrapper.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| tina/tina-lock.json | Updates Tina lockfile contents/version (appears unrelated to the routing consolidation). |
| components/last-updated-by/index.tsx | Changes “Last updated by” link to point to the internal /user?author=... page. |
| components/auth/UserDropdown.tsx | Repoints “SSW.Rules Profile” menu item from /profile to /user. |
| components/LatestRulesTable.tsx | Changes author links from GitHub to internal /user?author=... navigation. |
| app/user/page.tsx | Keeps /user as the wrapper page; updates metadata/title and continues passing ruleCount to the client page. |
| app/user/client-page.tsx | Expands the /user client page to render profile header + bookmarks (own profile) and unify behavior with author-based profiles. |
| app/profile/page.tsx | Deleted (profile functionality moved to /user). |
| app/profile/client-page.tsx | Deleted (bookmark/profile UI moved to /user). |
Comments suppressed due to low confidence (1)
app/user/client-page.tsx:92
- This client-side fetch uses a relative URL (
./api/...). Depending on whether the current URL ends with a trailing slash, this can resolve to/user/api/...instead of/api/...(and it also ignores the configured NextbasePath). Prefer an absolute path prefixed withBASE_PATH(or a sharedwithBasehelper) for API calls.
const res = await fetch(`./api/crm/employees?query=${encodeURIComponent(queryStringRulesAuthor)}`);
if (!res.ok) throw new Error("Failed to resolve author");
const profile = await res.json();
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
/deploy |
Contributor
PR Preview Deployed
This preview will be automatically deleted when the PR is closed. |
Aibono1225
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have very similar pages for the /profile and /user?author= routes. To clean this up and reduce code we want to combine these pages as differences between then were very small. Clicking the 'Last updated by ' will take user to the /user page instead of directly their GitHub profile.
Screenshot (optional)
Logged out - View user profile

Logged in - View own profile (includes Bookmarks)
