Skip to content

Remove unnecessary duplicated quote + from Twitter to X + remove Skype + improved social links area + many spacing improvements#811

Merged
Aibono1225 merged 19 commits intomainfrom
remove-unnecessary-duplicated-quote
Apr 8, 2026
Merged

Remove unnecessary duplicated quote + from Twitter to X + remove Skype + improved social links area + many spacing improvements#811
Aibono1225 merged 19 commits intomainfrom
remove-unnecessary-duplicated-quote

Conversation

@tiagov8
Copy link
Copy Markdown
Member

@tiagov8 tiagov8 commented Mar 27, 2026

as per @adamcogan 's email Re: SSW.People - Improve UI - consistent padding and RE: CRM - Remove Skype from Social Media


FROM

 

TO

@tiagov8 tiagov8 marked this pull request as ready for review March 27, 2026 21:34
@tiagov8 tiagov8 requested a review from griffenedge March 27, 2026 21:34
@tiagov8
Copy link
Copy Markdown
Member Author

tiagov8 commented Mar 30, 2026

Note: There is an email from @adamcogan to @zl24622 to remove Skype from this view: RE: CRM - Remove Skype from Social Media

Comment thread src/components/social-links/social-links.js Outdated
Co-authored-by: Griffen Edge <griffen@griffenedge.com>
@tiagov8
Copy link
Copy Markdown
Member Author

tiagov8 commented Apr 1, 2026

Hi @griffenedge

FYI - The social icons updates are in this PR: #815

@tiagov8 tiagov8 enabled auto-merge (squash) April 2, 2026 21:01
@tiagov8 tiagov8 requested a review from bradystroud April 2, 2026 21:02
auto-merge was automatically disabled April 2, 2026 23:01

Head branch was pushed to by a user without write access

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

Note: There is an email from @adamcogan to @zl24622 to remove Skype from this view: RE: CRM - Remove Skype from Social Media

Done in commit 4bbe40e — removed the Skype entry from the social links component and its corresponding displayCrm check.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • oembed.com
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/SSW.People/SSW.People/node_modules/.bin/gatsby build --prefix-paths (dns block)
  • unpkg.com
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node scripts/postinstall.js (dns block)
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/SSW.People/SSW.People/node_modules/.bin/gatsby build --prefix-paths (dns block)
    • Triggering command: /opt/hostedtoolcache/node/24.14.1/x64/bin/node /opt/hostedtoolcache/node/24.14.1/x64/bin/node /home/REDACTED/work/SSW.People/SSW.People/node_modules/gatsby-worker/dist/child.js (dns block)
  • www.ssw.com.au
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/SSW.People/SSW.People/node_modules/.bin/gatsby build --prefix-paths (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title Remove unnecessary duplicated quote + from Twitter to X + improved social links area Remove unnecessary duplicated quote + from Twitter to X + remove Skype + improved social links area Apr 2, 2026
@bradystroud
Copy link
Copy Markdown
Member

@copilot address the copilot feedback on the PR
#811 (review)

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 3, 2026

@copilot address the copilot feedback on the PR
#811 (review)

Both items from the copilot review were addressed in commit 4bbe40e:

  • Merge conflict markers in src/style.css resolved (keeping both .person-description and .favor-content rules)
  • CSS formatting fixed: margin:0 .5remmargin: 0 .5rem

@tiagov8
Copy link
Copy Markdown
Member Author

tiagov8 commented Apr 6, 2026

@copilot address the copilot feedback on the PR #811 (review)

Hi @bradystroud
How did that go?

@tiagov8 tiagov8 enabled auto-merge (squash) April 8, 2026 00:08
@tiagov8 tiagov8 disabled auto-merge April 8, 2026 00:08
@tiagov8 tiagov8 changed the title Remove unnecessary duplicated quote + from Twitter to X + remove Skype + improved social links area Remove unnecessary duplicated quote + from Twitter to X + remove Skype + improved social links area + many spacing improvements Apr 8, 2026
@Aibono1225 Aibono1225 enabled auto-merge (squash) April 8, 2026 13:40
@Aibono1225 Aibono1225 merged commit b082a90 into main Apr 8, 2026
2 checks passed
@Aibono1225 Aibono1225 deleted the remove-unnecessary-duplicated-quote branch April 8, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants