Fix data race in DebugFile class (Coverity CID 901301-901311)#859
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lemenkov
force-pushed
the
new_coverity
branch
2 times, most recently
from
fd19ef6 to
c669284
Compare
Move std::lock_guard acquisition before checking fp pointer to prevent race conditions. The previous pattern checked fp without holding the lock, then acquired the lock and checked again, but another thread could modify fp between the unlocked check and lock acquisition. Signed-off-by: Peter Lemenkov <lemenkov@gmail.com> Assisted-by: Claude (Anthropic) <https://claude.ai>
orgads
approved these changes
Mar 12, 2026
Contributor
orgads
left a comment
orgads
left a comment
There was a problem hiding this comment.
I think the report is false positive, because the file is never closed while multiple threads are running, but since mutex lock is very fast on most cases I'll pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @orgads
Move std::lock_guard acquisition before checking fp pointer to prevent race conditions. The previous pattern checked fp without holding the lock, then acquired the lock and checked again, but another thread could modify fp between the unlocked check and lock acquisition.