Fix memory leaks in template Setup() bitmap loading#4
Open
EddieMac74 wants to merge 1 commit intoSDRplay:masterfrom
Open
Fix memory leaks in template Setup() bitmap loading#4EddieMac74 wants to merge 1 commit intoSDRplay:masterfrom
EddieMac74 wants to merge 1 commit intoSDRplay:masterfrom
Conversation
Nine BYTE arrays allocated with new[] were never freed after being passed to Nana's img.open(). Added matching delete[] calls immediately after all open() calls. Also removed unused barfocusedPixels pointer that was declared but never initialized or referenced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nine
BYTEarrays allocated withnew[]inSDRunoPlugin_TemplateForm::Setup()were never freed after being passed to Nana'simg.open(). Since Nana copies the data internally duringopen(), the buffers serve no purpose after that call and should be released immediately.Also removed the unused
barfocusedPixelspointer which was declared but never initialized or referenced.Affected file:
SDRunoPlugin_Template/SDRunoPlugin_TemplateForm.cppNote: the same pattern exists in any plugin derived from this template and should be fixed there too.