Modernize zipfile usage in zip tool#4850
Merged
bdbaddog merged 1 commit intoSCons:masterfrom May 5, 2026
Merged
Conversation
SCons/Tool/zip.py had a TODO suggesting there was more native way to create ZipInfo objects once Python 3.6 became the SCons minimum. This was not implemented yet so this change provides that update. Also adds a bit of type annotation. Signed-off-by: Mats Wichmann <mats@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SCons/Tool/zip.pyhad a TODO suggesting there was more native way to createZipInfoobjects once Python 3.6 became the SCons minimum. This was not implemented yet so this change provides that update. Also adds a bit of type annotation.No test changes: the existing tests verify the behavior did not change; this is not visible to users.
Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).