Added looping feature to cache videos#99
Conversation
![sce-pr-review-bot[bot]](https://avatars.githubusercontent.com/u/180733079?s=60&v=4){kind=small}
|
|
||
| # terminate a parent process and all its child processes using a specified signal. | ||
| def kill_child_processes(parent_pid, sig=signal.SIGKILL): | ||
| def kill_child_processes(parent_pid, sig=signal.SIGILL): |
There was a problem hiding this comment.
[CRITICAL] The change from signal.SIGKILL to signal.SIGILL in kill_child_processes is incorrect. SIGILL (Illegal Instruction) is not intended for process termination and can be caught or ignored by a process, potentially preventing it from being killed. SIGKILL is the appropriate signal for forceful, unblockable termination.
| <div id="listOfVideosContainer" > | ||
| </div> | ||
| <script> | ||
| let holdTimer; |
There was a problem hiding this comment.
[CRITICAL] The togglePlayVideo function is defined twice. The inner definition async function togglePlayVideo(e, video) at line 22 shadows the outer definition async function togglePlayVideo(e, video, isLooping) at line 20. As a result, the isLooping parameter will always be undefined within the function that makes the fetch request, preventing the video looping functionality from working. The inner function should be removed, and the outer function should contain the logic.
2 participants
No description provided.