ci: add OSPO branch protection and environment-scoped workflows#20
Merged
Conversation
Adds repo ruleset on `main` (PR + CI `test` check required, blocks force-push and deletion, admin bypass). Wires publishing/secret-using workflows to GitHub Environments: release.yml -> release, sign-windows.yml + release-tray.yml -> signing (required reviewer), news-sync.yml -> news-sync. Documents the new approval gate in the CLAUDE.md release section. Follow-up (manual): scope SIGNPATH_* secrets to the signing environment and YOUTUBE_API_KEY to the news-sync environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements OSPO requirements for
mainbranch protection and secret-handling workflow protection.main-protection(already created via API, JSON spec checked in at .github/rulesets/main-protection.json): requires PR + CItestcheck, blocks force-push and deletion, admin bypass enabled.release—release.ymlruns heresigning—release-tray.ymlandsign-windows.ymlrun here, requires manual approval from a repo admin (currentlyjung-thomas)news-sync—news-sync.ymlruns hereenvironment:declarations on the relevant jobs.Test plan
testcheck passingmain-protectionruleset is visible at https://github.com/SAP-samples/sap-devs-cli/rulesSIGNPATH_*secrets tosigningenvironment andYOUTUBE_API_KEYtonews-syncenvironment (currently inherited from org level)sign-windows.ymlwill pause for required-reviewer approval — verify the notification flow works end-to-endNotes
release.ymlpushing tags viaGITHUB_TOKEN(see CLAUDE.md release section).