happy path for saving state of differnet segment bitrates and showing each of the status bars to the client#78
Merged
Conversation
… each of the status bars to the client
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds end-to-end “transcoding progress” tracking (persisted in Postgres and streamed via RabbitMQ/WebSocket) and exposes per-bitrate progress bars in the frontend so clients can see low/medium/high transcode completion.
Changes:
- Persist per-segment transcode state in Postgres and publish
transcode_progressstatus events. - Extend upload-status WebSocket to send a transcode progress snapshot on connect.
- Update the frontend to render and finalize completion based on per-profile transcode progress.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-service/src/main/java/com/distributed26/videostreaming/upload/upload/UploadStatusWebSocket.java | Adds transcode progress snapshot emission on WS bind. |
| upload-service/src/main/java/com/distributed26/videostreaming/upload/upload/UploadServiceApplication.java | Wires TranscodedSegmentStatusRepository into the status app. |
| upload-service/src/main/java/com/distributed26/videostreaming/upload/db/TranscodedSegmentStatusRepository.java | New repo for reading transcode status counts from Postgres. |
| upload-service/docs/db/schema.sql | Adds transcoded_segment_status table + index. |
| shared/src/main/java/com/distributed26/videostreaming/shared/upload/events/TranscodeSegmentState.java | New enum for transcode state machine. |
| shared/src/main/java/com/distributed26/videostreaming/shared/upload/events/TranscodeProgressEvent.java | New JobTaskEvent subtype for reporting transcode progress. |
| shared/src/main/java/com/distributed26/videostreaming/shared/upload/RabbitMQJobTaskBus.java | Adds parsing/typing support for transcode_progress messages. |
| processing-service/src/main/java/com/distributed26/videostreaming/processing/db/TranscodedSegmentStatusRepository.java | New repo for upserting per-segment state and counting DONE segments. |
| processing-service/src/main/java/com/distributed26/videostreaming/processing/TranscodingWorker.java | Emits TRANSCODING/UPLOADING/DONE/FAILED state transitions. |
| processing-service/src/main/java/com/distributed26/videostreaming/processing/TranscodingTask.java | Adds a pre-upload callback and enables audio encoding. |
| processing-service/src/main/java/com/distributed26/videostreaming/processing/ProcessingServiceApplication.java | Tracks total segments, publishes transcode progress events, and triggers manifest generation when complete. |
| processing-service/pom.xml | Adds Postgres JDBC dependency. |
| frontend/index.html | Adds UI blocks for Low/Medium/High transcode progress. |
| frontend/app.js | Handles transcode_progress events, updates per-profile UI, and finalizes success when all profiles complete. |
| docker_compose.swarm.yaml | Passes PG_* env vars into processing service. |
| docker-compose.yaml | Configures processing service PG_URL/PG_USER/PG_PASSWORD env vars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ing/processing/ProcessingServiceApplication.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ing/processing/ProcessingServiceApplication.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@tani-gross I've opened a new pull request, #79, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.