Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds comprehensive integration tests for file-based S3 uploads using the Java AWS SDK, improves S3 multipart upload ETag handling, and enhances the system test infrastructure to support the high-level S3 Transfer Manager. The changes ensure that multipart and single-part uploads are correctly tested and that S3-compatible responses include appropriate ETags, improving compatibility with S3 clients and SDKs.
S3 ETag Handling Improvements:
putOrUploadPartHandlerandbuildCompleteMultipartUploadXml, ensuring S3 client compatibility. [1] [2] [3]System Test Enhancements:
Boto3UploadFileITthat tests single-part uploads, multipart uploads, and uploads via the high-levelS3TransferManager.uploadFile, verifying round-trip integrity for each method.s3-transfer-managerdependency tosystem-tests/pom.xmlto enable use of the high-level transfer manager in tests.Test Infrastructure Upgrades:
DockerComposeS3E2EIT) to initialize and clean upS3AsyncClientandS3TransferManager, and to configure multipart thresholds and checksum validation for more realistic S3 client behavior. [1] [2] [3] [4]