fix(android): showing seemingly duplicate devices naming#1109
Merged
roderickvd merged 6 commits intoRustAudio:masterfrom Mar 2, 2026
Merged
fix(android): showing seemingly duplicate devices naming#1109roderickvd merged 6 commits intoRustAudio:masterfrom
roderickvd merged 6 commits intoRustAudio:masterfrom
Conversation
roderickvd
reviewed
Mar 1, 2026
Member
roderickvd
left a comment
roderickvd
left a comment
There was a problem hiding this comment.
Some questions - and if you would also write a changelog entry?
| let device_type: DeviceType = info.device_type.into(); | ||
| let name = match device_type { | ||
| DeviceType::Unknown => info.product_name.clone(), | ||
| _ => format!("{} ({})", info.product_name, device_type), |
Member
There was a problem hiding this comment.
@SuperKenVery was arguing that it should include the address. I'm not so sure because an address is not a name. What do you think?
Contributor
Author
There was a problem hiding this comment.
For my case, device_type is unique enough to distinguish the device.
Contributor
Author
There was a problem hiding this comment.
@roderickvd I added the changelog entry.
roderickvd
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #969
This pull request improves the handling and description of audio devices in the
aaudiohost implementation. The main changes enhance device naming clarity and ensure that input/output configurations are only provided for devices that actually support them.Device description and naming improvements:
src/host/aaudio/mod.rs)Input/output configuration filtering:
src/host/aaudio/mod.rs)src/host/aaudio/mod.rs)See the issue ticket for more screenshots.
After
Before
Related #1103