-
-
Notifications
You must be signed in to change notification settings - Fork 44
fix: add desktop drag scrolling for horizontal rows #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlejandroAkbal
wants to merge
1
commit into
main
Choose a base branch
from
auto-triage/270-feature-scroll-horizontally-on-desktop-by-click-dragging-or-with-scrolling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+141
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| import { useEventListener } from '@vueuse/core' | ||
| import type { Ref } from 'vue' | ||
|
|
||
| const DRAG_THRESHOLD = 4 | ||
|
|
||
| export function useDesktopHorizontalScroll<T extends HTMLElement>(scrollContainerRef: Ref<T | null>) { | ||
| let activePointerId: number | null = null | ||
| let dragStartX = 0 | ||
| let dragStartScrollLeft = 0 | ||
| let didDrag = false | ||
| let shouldPreventClick = false | ||
|
|
||
| function onWheel(event: WheelEvent) { | ||
| const scrollContainer = scrollContainerRef.value | ||
|
|
||
| if (!scrollContainer) { | ||
| return | ||
| } | ||
|
|
||
| // Preserve touchpad/native horizontal behavior and only map normal mouse wheel. | ||
| if (event.deltaX !== 0 || event.deltaY === 0 || !isLikelyMouseWheel(event)) { | ||
| return | ||
| } | ||
|
|
||
| const maxScrollLeft = scrollContainer.scrollWidth - scrollContainer.clientWidth | ||
|
|
||
| if (maxScrollLeft <= 0) { | ||
| return | ||
| } | ||
|
|
||
| const canScrollLeft = scrollContainer.scrollLeft > 0 | ||
| const canScrollRight = scrollContainer.scrollLeft < maxScrollLeft | ||
|
|
||
| if ((event.deltaY < 0 && !canScrollLeft) || (event.deltaY > 0 && !canScrollRight)) { | ||
| return | ||
| } | ||
|
|
||
| event.preventDefault() | ||
|
|
||
| scrollContainer.scrollLeft += event.deltaY | ||
| } | ||
|
|
||
| function onPointerDown(event: PointerEvent) { | ||
| const scrollContainer = scrollContainerRef.value | ||
|
|
||
| if (!scrollContainer || event.pointerType !== 'mouse' || event.button !== 0) { | ||
| return | ||
| } | ||
|
|
||
| const maxScrollLeft = scrollContainer.scrollWidth - scrollContainer.clientWidth | ||
|
|
||
| if (maxScrollLeft <= 0) { | ||
| return | ||
| } | ||
|
|
||
| activePointerId = event.pointerId | ||
| dragStartX = event.clientX | ||
| dragStartScrollLeft = scrollContainer.scrollLeft | ||
| didDrag = false | ||
|
|
||
| scrollContainer.setPointerCapture(event.pointerId) | ||
| } | ||
|
|
||
| function onPointerMove(event: PointerEvent) { | ||
| const scrollContainer = scrollContainerRef.value | ||
|
|
||
| if (!scrollContainer || activePointerId !== event.pointerId) { | ||
| return | ||
| } | ||
|
|
||
| const dragDistance = event.clientX - dragStartX | ||
|
|
||
| if (!didDrag && Math.abs(dragDistance) >= DRAG_THRESHOLD) { | ||
| didDrag = true | ||
| } | ||
|
|
||
| if (!didDrag) { | ||
| return | ||
| } | ||
|
|
||
| event.preventDefault() | ||
|
|
||
| scrollContainer.scrollLeft = dragStartScrollLeft - dragDistance | ||
| } | ||
|
|
||
| function endDrag(event: PointerEvent) { | ||
| const scrollContainer = scrollContainerRef.value | ||
|
|
||
| if (!scrollContainer || activePointerId !== event.pointerId) { | ||
| return | ||
| } | ||
|
|
||
| if (scrollContainer.hasPointerCapture(event.pointerId)) { | ||
| scrollContainer.releasePointerCapture(event.pointerId) | ||
| } | ||
|
|
||
| shouldPreventClick = didDrag | ||
| didDrag = false | ||
| activePointerId = null | ||
| } | ||
|
|
||
| function onClickCapture(event: MouseEvent) { | ||
| if (!shouldPreventClick) { | ||
| return | ||
| } | ||
|
|
||
| event.preventDefault() | ||
| event.stopPropagation() | ||
|
|
||
| shouldPreventClick = false | ||
| } | ||
|
|
||
| useEventListener(scrollContainerRef, 'wheel', onWheel, { passive: false }) | ||
| useEventListener(scrollContainerRef, 'pointerdown', onPointerDown) | ||
| useEventListener(scrollContainerRef, 'pointermove', onPointerMove) | ||
| useEventListener(scrollContainerRef, 'pointerup', endDrag) | ||
| useEventListener(scrollContainerRef, 'pointercancel', endDrag) | ||
| useEventListener(scrollContainerRef, 'click', onClickCapture, { capture: true }) | ||
| } | ||
|
|
||
| function isLikelyMouseWheel(event: WheelEvent) { | ||
| if (event.deltaMode !== WheelEvent.DOM_DELTA_PIXEL) { | ||
| return true | ||
| } | ||
|
|
||
| return Number.isInteger(event.deltaY) && Math.abs(event.deltaY) >= 40 | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In browser wheel event handling, does preventDefault() on a wheel event with ctrlKey=true suppress page zoom behavior?💡 Result:
Yes—when the
wheelevent is cancelable and your listener is non-passive, callingevent.preventDefault()on awheelevent withctrlKey === truesuppresses the browser’s default page-zoom (Ctrl+wheel / trackpad-pinch-zoom) behavior. MDN notes that zoom gestures firewheelevents withctrlKeyset, and that canceling the event prevents “scrolling or zooming.” [1]Practical requirements / caveats:
{ passive: false }, otherwise the browser may ignorepreventDefault()for performance reasons. [1]Sources: [1] MDN wheel event docs, [2] W3C Wheel Events spec, [3] Chromium blink-dev “ctrl+mousewheel events can now be overridden”.
🏁 Script executed:
fd -t f "useDesktopHorizontalScroll.ts"Repository: Rule-34/App
Length of output: 96
🏁 Script executed:
Repository: Rule-34/App
Length of output: 4317
Add early return for zoom gestures (Ctrl+wheel) in wheel handler.
The wheel event listener at line 113 is registered with
{ passive: false }, which meansevent.preventDefault()at line 38 will effectively suppress browser default behavior. Without checkingevent.ctrlKeyfirst, this prevents page zoom when using Ctrl+wheel. Add a check for zoom gestures to the early return condition:Proposed patch
📝 Committable suggestion
🤖 Prompt for AI Agents