fix: path resolution problems in Windows#69
Merged
Conversation
Agent-Logs-Url: https://github.com/RocketChat/Rocket.Chat.Apps-compiler/sessions/26cb786c-abca-4604-a428-aa2bd30172ea Co-authored-by: d-gubert <1810309+d-gubert@users.noreply.github.com>
|
|
Copilot stopped work on behalf of
d-gubert due to an error
May 25, 2026 15:54
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to extend CI coverage to Windows and fixes several path-handling issues (primarily path separator normalization) so compilation/bundling/packaging behavior is consistent across operating systems.
Changes:
- Split CI into a Linux-only “Lint & Typecheck” job and a matrix “Test” job running on both Ubuntu and Windows.
- Normalize internal file/module paths to POSIX-style (
/) across compiler, validator, bundler, packager, and source-walking code paths. - Update
package-lock.jsonas part of dependency metadata adjustments.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/packager/AppPackager.ts |
Normalize zip entry paths to forward slashes for Windows-compatible packaging. |
src/misc/Utilities.ts |
Use path.posix normalization for custom-require module path handling. |
src/compiler/TypescriptCompiler.ts |
Normalize filenames/host lookups using POSIX paths and separator replacement for Windows compatibility. |
src/compiler/TscBasedCompiler.ts |
Ensure emitted file keys use POSIX joining for stable map keys across OSes. |
src/compiler/getAppSource.ts |
Normalize relative file names to POSIX separators when building the in-memory file map. |
src/compiler/AppsEngineValidator.ts |
Switch relative require resolution to POSIX join/normalize for consistency. |
src/bundler/esbuild.ts |
Simplify and standardize relative module path normalization using POSIX path operations. |
package-lock.json |
Lockfile metadata updates (engines/peer flags changes). |
.github/workflows/ci.yml |
Add Windows to test matrix; separate tests from lint/typecheck. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d-gubert
changed the title
d-gubert
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.