fix(auth): resolve context loss causing TypeError in secure auth methods#1273
Open
amankv1234 wants to merge 2 commits intoRocketChat:developfrom
Open
fix(auth): resolve context loss causing TypeError in secure auth methods#1273amankv1234 wants to merge 2 commits intoRocketChat:developfrom
amankv1234 wants to merge 2 commits intoRocketChat:developfrom
Conversation
Author
|
Hi @7vignesh, I have submitted this pull request with improvements related to type safety and code cleanup. I would really appreciate your feedback, and if everything looks good, kindly consider merging it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves Issue #1225 where users logged in via the secure authentication flow were encountering a
TypeError: Cannot read properties of undefined (reading 'handleSecureLogin')crash.Root Cause:
In modern environments enforcing ES strict mode,
thisevaluates toundefinedfor standalone function declarations at the module level. WhensaveTokenSecure,getTokenSecure, anddeleteTokenSecurewere passed across modules intoRocketChatAuth, the transpiler stripped theirthisbindings. Consequently, attempting to callthis.handleSecureLoginwithin them resulted in an immediate crash.Solution:
Refactored
getTokenStorageto return the token handlers as object literal methods directly. Moving them from standalone function declarations into object methods ensures lexical scoping is preserved properly when executed within the boundaries of theRocketChatAuthinstance, thus maintaining thethiscontext correctly.Fixes #1225
Changes Made
packages/react/src/lib/auth.jsto return object methods directly ingetTokenStorage.saveTokenSecure, etc.) that were losing context.Steps to Test
secure: trueconfiguration.