Open
Conversation
- Fixed wrapper issues in code
- Added a scroll bar to code uploader - Addded connet button
- So we can setup file manager easily in that way
…/Nexus-Tools into feature/turtle_intergration
…ticGen/Nexus-Tools into feature/code_uploader
- UI fixes in REPL - Disconneted issue in ESP32
- currently can view files in esp32 - currently can download each file separatly
- Now user can view file content from esp32
- users can access each by swithcing tabs
- Users an get multiple tabs and code - Also file manager view files using code editor -
- removed uncessary functions
… feature/code_uploader
AnasSAV
reviewed
Mar 14, 2026
| @@ -0,0 +1,4 @@ | |||
| # Netscape HTTP Cookie File | |||
Contributor
There was a problem hiding this comment.
Can you remove this HTTP cookie file. Can you add .gitignore if not needed
| @@ -0,0 +1,112 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
Is this file also necessary. Can you add .gitignore if not needed. If we are adding test cases, can you write it down seperately
| @@ -0,0 +1,303 @@ | |||
| /** | |||
Contributor
There was a problem hiding this comment.
WebSerialPortAdapter in manages its own reader/writer via startTransaction(). But SerialStreamManager already holds the exclusive reader/writer lock on the same port from the moment initialize() is called. Calling startTransaction() on the same port after SerialStreamManager is initialized would throw "stream is locked. This class is exported from the package index but is not used anywhere in the new code it's dead code that is also a landmine. Remove it or clearly mark it internal.
| if (typeof window === "undefined") return false; | ||
|
|
||
| const hasSerial = "serial" in navigator; | ||
| const isSecureContext = |
Contributor
There was a problem hiding this comment.
window isSecureContext already returns true for localhost and https: in all modern browsers. The extra conditions are redundant.
| } finally { | ||
| // Don't close the port after upload - keep it for future uploads | ||
| // Only close if there was an error and no existing connection | ||
| if (!connectedPortRef.current && port) { |
Contributor
There was a problem hiding this comment.
Double cleanup risk In finally
But closePort calls serialStreamManager.cleanup() which clears the singleton regardless of which port is being closed. If a different port is connected at this point, the singleton gets wiped.
| @@ -0,0 +1,219 @@ | |||
| /* ESP32 Uploader - Ant Design Component Overrides */ | |||
Contributor
There was a problem hiding this comment.
Why an overrides.css can we define the same css in global.css
Contributor
Feature Testing Rubric – ESP32 Code Uploader & File ManagerFeature Overview
Scoring Guide
1. Requirements & UI Coverage
2. Functional UI TestingConnection Flow
Code Upload
REPL Terminal (OBO Code)
Device File Manager
Multi-Tab Code Editor
3. ESP32 Communication Parity Check
4. Input Validation & Edge Cases
5. Browser & Device Compatibility
6. Performance Testing
7. Critical Issues from Code Review
8. UI IssuesNot Mobile/Tab Responsive
Tester Sign-off
|
- Added new run in esp32 button - changed place in skulpt canvas
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File uploder and Manager for obo code and obo blocks
After connecting we can acess files inside of esp 32 delete update
For testing for REPL use this Kind of one line code
from machine import Pin; import time; led=Pin(2,Pin.OUT); exec("while True: led.value(not led.value()); time.sleep(0.5)")