Skip to content

fix: make dynmsg work on all unix platforms #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruben-arts wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make dynmsg work on all unix platforms #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
378dfb2
fix: move dynmsg to unix builds and addapt the patch to make that work.
ruben-arts May 18, 2026
88ddb1e
small update on the pixi.toml
ruben-arts May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions patch/ros-humble-dynmsg.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,15 @@ index 072819c..ed4716f 100644
case rosidl_typesupport_introspection_cpp::ROS_TYPE_MESSAGE:
// For nested types, don't copy the data out of the buffer directly. Recursively read the
// nested type into the YAML.
@@ -398,7 +398,7 @@ dynamic_array_to_yaml_impl_bool(
static_cast<void>(member_info);
for (size_t ii = 0; ii < v->size(); ++ii) {
DYNMSG_DEBUG(std::cout << (v->operator[](ii) ? "true" : "false") << ", ");
- array_node.push_back(v->operator[](ii));
+ array_node.push_back(static_cast<bool>(v->operator[](ii)));
}
DYNMSG_DEBUG(std::cout << std::endl);
}
@@ -509,12 +509,12 @@ dynamic_array_to_yaml(
reinterpret_cast<const std::vector<std::string> *>(member_data),
array_node);
Expand Down
Loading