Refactor connections, remove Plaid, add view creation API#66
Merged
Conversation
- Updated the SDK aliases to improve clarity by renaming `RoboSystemsClient` for better understanding. - Added `RoboSystemsClient` to the `__all__` export list to ensure it is accessible for users of the SDK. These changes enhance the usability and readability of the SDK's interface.
- Removed the `ElementMappingClient` and associated classes from the codebase to streamline the SDK and eliminate unused functionality. - Updated the `ViewBuilderClient` to remove references to the `ElementMappingClient`, simplifying its initialization and method signatures. These changes enhance the clarity and maintainability of the SDK by focusing on essential components.
…e functionality and enhance clarity.
…ection models - Eliminated all Plaid-related documentation and references from the connection API files, including `create_connection.py`, `get_connection_options.py`, `sync_connection.py`, and `list_connections.py`. - Updated the `ConnectionResponse` and `CreateConnectionRequest` models to remove Plaid-specific attributes and adjust entity_id handling. - Deleted unused Plaid connection configuration models to streamline the codebase. These changes enhance clarity and focus on the remaining connection providers, improving maintainability of the SDK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the connection subsystem by removing Plaid integration, streamlining the element mapping architecture, and introducing a new View creation API with supporting models. The changes simplify the SDK surface area while adding new view-building capabilities.
Key Accomplishments
Plaid Integration Removal
PlaidConnectionConfigmodel and all Plaid-specific references from connection-related filesConnectionProviderInfoProvider,CreateConnectionRequestProvider, andListConnectionsProviderType0ConnectionResponseandCreateConnectionRequestmodels by removing Plaid-specific configuration branchesSecConnectionConfigmodelConnection API Cleanup
create_connection,get_connection_options, andsync_connectionAPI endpointslist_connectionsAPINew View Creation API
api/views/module with acreate_viewendpointCreateViewRequest,ViewConfig,ViewAxisConfig,ViewAxisConfigElementLabelsType0, andViewAxisConfigMemberLabelsType0Element Mapping Client Removal & View Builder Refactor
element_mapping_client.py(585 lines removed) and removed its export from the extensions moduleViewBuilderClientby removing element mapping references, enhancing clarity of the view builder's responsibilities__init__.pyto reflect the new module structureBreaking Changes
PlaidConnectionConfigmodel has been removed — any code referencing Plaid connections will breakElementMappingClientextension has been deleted — consumers must migrate away from this clientViewBuilderClientAPI surface has changed — element mapping methods are no longer available through this clientcreate_connection,get_connection_options,sync_connection) have reduced functionality — callers passing Plaid-specific parameters will need to be updated__init__.pyhave been refactored — import paths may need updatingTesting Notes
create_viewendpoint with variousViewConfigandViewAxisConfigcombinationsViewBuilderClientoperates correctly without element mapping dependenciesSecConnectionConfigchanges are backward-compatible for existing SEC-based connectionsInfrastructure Considerations
create_viewroute before deploymentElementMappingClientfunctionality🤖 Generated with Claude Code
Branch Info:
feature/connection-improvementsmainCo-Authored-By: Claude noreply@anthropic.com