Consolidate test fixtures for consistency#3
Merged
Conversation
- Add grad_precision_tolerance fixture to conftest.py (1e-3) - Update sample_data to use shared rng_key and sample_size fixtures - Change sample size from 5 to 1000 for consistency with bijection tests - Use grad_precision_tolerance parameter in test_round_trip_grad_precision All test configurations now centralized in conftest.py.
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates test configuration by moving shared fixtures and constants to conftest.py, improving test consistency and maintainability across the test suite.
- Adds
grad_precision_tolerancefixture to centralize gradient test tolerances - Updates
sample_datafixture to use sharedrng_keyandsample_sizefromconftest.py - Standardizes sample size to 1000 across gradient and bijection tests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/conftest.py | Adds grad_precision_tolerance fixture (1e-3) for gradient precision tests |
| tests/test_dataloader_jax_grad.py | Refactors sample_data fixture to use centralized rng_key and sample_size fixtures; updates gradient precision test to use grad_precision_tolerance parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Centralizes test configuration in conftest.py and improves fixture reuse across test modules.
Changes
Result
All test configurations now centralized in conftest.py
Consistent sample sizes (1000) across test suites
Configurable tolerances in one location