Unstyled Donation pages, I have pushed them since I am handing the t…#99
Open
sjumba wants to merge 1 commit into
Open
Unstyled Donation pages, I have pushed them since I am handing the t…#99sjumba wants to merge 1 commit into
sjumba wants to merge 1 commit into
Conversation
|
|
||
| //import { validatePassword, validateEmail, validateUsername } from './Validators.js'; | ||
| import { BrowserRouter, Route, Switch, NavLink } from "react-router-dom"; | ||
| /* <form> |
Collaborator
There was a problem hiding this comment.
GC has been preached many times.
Please remove it
| <form> | ||
| <h>Payments</h><br/> | ||
| Credit card number <input type="number" name="card number" placeholder="1234567890"/><br/><br/> | ||
| Expiration date <input type="date" name="ExpDate" placeholder="1234567890"/><br/><br/> |
Collaborator
There was a problem hiding this comment.
The expiration field of credit cards is usually made of the month and the year in two separated fields.
e.g: exp month: MM || exp year: YYYY
|
|
||
| export default donation; | ||
| {/* <form> | ||
| <FormGroup controlId="CardNumber" > |
Collaborator
There was a problem hiding this comment.
Remove your GC codes here too.
| <div> | ||
|
|
||
|
|
||
| <h>Thank you</h><br/> |
Collaborator
There was a problem hiding this comment.
Which h is this tag?
h1, h2, h3, h4, h5 or h6?
| <img alt="" border="0" src="https://www.paypal.com/en_ZA/i/scr/pixel.gif" width="1" height="1" /> | ||
| </form> | ||
| */ | ||
| class donationSuccess extends Component { |
Collaborator
There was a problem hiding this comment.
You have so many spaces between your elements.
How does it look like?
Exactly like this!
Is it ok?
No!
Please make sure that you have few of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ask over to Kyle.