Fix tooltip registration logic for Retail vs Classic/TBC#346
Open
Skyrisu wants to merge 3 commits intoRestedXP:mainfrom
Open
Fix tooltip registration logic for Retail vs Classic/TBC#346Skyrisu wants to merge 3 commits intoRestedXP:mainfrom
Skyrisu wants to merge 3 commits intoRestedXP:mainfrom
Conversation
…s Classic/TBC Issue: TBC Anniversary has TooltipDataProcessor object but the AddTooltipPostCall method doesn't work
Author
|
Should be fine checking only for: "_G.TooltipDataProcessor.AddTooltipPostCall" but I added it on top to be sure |
Skyrisu
commented
Jan 25, 2026
Author
Skyrisu
left a comment
Skyrisu
left a comment
There was a problem hiding this comment.
Fix wasn't working properly. I added a helper variable to check if the function got executed properly to fall back to hookscript if not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the tooltip registration logic to ensure proper detection and functionality for the TBC Anniversary context.