You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is something I did a while ago. It is a hack to allow all of my sideloaded resources of a paged model to be loaded rather than just the same total number as the primary resource.
Currently what appears to happen is that you get the page size number of sideloads which isn't what I want.
Ideally the page size would apply to the individual items in the paged model, but I couldn't figure out the sql to do that in one call and I didn't want to be doing a call per model, so I rolled back the option code I wrote to allow it to be passed in.
I think primarily this is an sql problem.
It is an ugly hack, so I'd like to see something nicer.
My current thoughts on this are that "side loading" isn't really
appropriate for what I use it for, i.e. comments on messages, as comments
are associated with only a single message. Therefore I plan to refactor to
insert the comments directly into the JSON rather than merely reference
them. I will put logic in the serializer to deal with page size if I need
it.
Side loading/links seems better suited to many-to-many relationships where
the associated entities are referred to by many first order elements..
On a similar note, I'm finding I want my side loaded entities to be either
fully loaded, or the same page size as set on my query.
Any thoughts on:
Having an "all" option for paging. You can always pass a large page
size, but it would be nice when I just want everything
Having an "all" option for side loading. It would be great on sub
relations to be able to pull everything in all at once.
—
Reply to this email directly or view it on GitHub #96 (comment)
.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something I did a while ago. It is a hack to allow all of my sideloaded resources of a paged model to be loaded rather than just the same total number as the primary resource.
Currently what appears to happen is that you get the page size number of sideloads which isn't what I want.
Ideally the page size would apply to the individual items in the paged model, but I couldn't figure out the sql to do that in one call and I didn't want to be doing a call per model, so I rolled back the option code I wrote to allow it to be passed in.
I think primarily this is an sql problem.
It is an ugly hack, so I'd like to see something nicer.