The Profiler Performance Engineering#26
Merged
stalep merged 8 commits intoRedHatPerf:devfrom Mar 27, 2026
Merged
Conversation
diegolovison
force-pushed
the
new_post
branch
from
7f9019b to
52b183f
Compare
stalep
reviewed
Dec 8, 2025
stalep
reviewed
Jan 30, 2026
stalep
reviewed
Mar 26, 2026
There was a problem hiding this comment.
Outstanding items from previous reviews
- Title (line 2): Still shows the original. You proposed "Profiler Performance Engineering: A Story of What It Does and Doesn't Show" but it hasn't been applied yet.
- Injection rate specifics (lines 104-108): Previous request to include concrete rates. You proposed wording but it hasn't been applied.
- SDLC/Personas & USE Method sections: Still an open discussion on whether they add enough value (cc @franz1981).
Mostly syntax improvements in comments below. Otherwise I think it looks good. The above comments are not showstoppers for me.
Contributor
Author
|
@stalep done. I also addressed the following as new commits ( I assumed that you agree with my proposal )
|
stalep
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.