Skip to content

HMS-10056: Add tests for satellite managed systems#1529

Merged
Dugowitch merged 2 commits intoRedHatInsights:masterfrom
Dugowitch:hms10056
Mar 9, 2026
Merged

HMS-10056: Add tests for satellite managed systems#1529
Dugowitch merged 2 commits intoRedHatInsights:masterfrom
Dugowitch:hms10056

Conversation

@Dugowitch
Copy link
Copy Markdown
Contributor

@Dugowitch Dugowitch commented Mar 2, 2026

Description

Associated Jira ticket: #HMS-10056

Add a satellite-managed system and add a test that checks:

  • template column label is "Managed by Satellite"
  • there are corresponding alerts in system's details
  • the satellite-managed system cannot be assigned to a template

Checklist:

  • The commit message has the Jira ticket linked
  • PR has a short description
  • Screenshots before and after the change are added
  • Tests for the changes have been added
  • README.md is updated if necessary
  • Needs additional dependent work

@Dugowitch Dugowitch force-pushed the hms10056 branch 2 times, most recently from 116319c to 40c150f Compare March 2, 2026 15:39
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.67%. Comparing base (5d8712e) to head (a7dc55c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1529   +/-   ##
=======================================
  Coverage   73.67%   73.67%           
=======================================
  Files          97       97           
  Lines        2359     2359           
  Branches      666      666           
=======================================
  Hits         1738     1738           
  Misses        551      551           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dugowitch Dugowitch force-pushed the hms10056 branch 3 times, most recently from b9c3aa3 to a151c89 Compare March 3, 2026 11:59
@Dugowitch Dugowitch marked this pull request as ready for review March 3, 2026 12:47
@Dugowitch Dugowitch requested a review from a team as a code owner March 3, 2026 12:47
@Dugowitch
Copy link
Copy Markdown
Contributor Author

/retest

@Dugowitch Dugowitch marked this pull request as draft March 4, 2026 16:41
@Dugowitch Dugowitch marked this pull request as ready for review March 4, 2026 16:58
@Dugowitch
Copy link
Copy Markdown
Contributor Author

/retest

Copy link
Copy Markdown
Collaborator

@dominikvagner dominikvagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! ✨
ack ✅ thx!

@Dugowitch Dugowitch merged commit f4a7c82 into RedHatInsights:master Mar 9, 2026
6 of 8 checks passed
@Dugowitch Dugowitch deleted the hms10056 branch March 9, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants