test: migrate feedback tests from IQE (RHCLOUD-44391)

[catastrophe-brandon]

Summary

Migrates feedback tests from IQE test_feedback.py to Playwright.

Migrated from IQE

iqe_platform_ui/tests/test_feedback.py

Tests Migrated

Test 1: should open and close feedback form

• Opens help panel
• Navigates to Share feedback tab
• Clicks Share feedback card
• Verifies form is visible
• Clicks Back button
• Verifies return to feedback home

Markers: @pytest.mark.qa

Test 2: should submit feedback successfully

• Opens help panel and navigates to feedback form
• Fills in feedback with random text
• Submits feedback
• Verifies success message displayed
• Verifies 'Share more feedback' button appears

Markers: @pytest.mark.core

Note: Only runs on stage/prod environments where submission is enabled.

What's NOT Migrated

• JIRA API verification of ticket creation (manual verification may be needed)
• The automated test verifies the form submission succeeds but does not query JIRA to confirm ticket details

Requirements

• PLATFORM_UI-FEEDBACK
• PLATFORM_UI-INSIGHTS_CHROME

Related

• Continues IQE test migration effort in learning-resources repository

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Adds two Playwright E2E test specs: one automates the Help panel Feedback workflow (open form, back navigation, submit, success UI), and one verifies Help panel Support Cases flows (empty-state vs table handling, external "Open a support case" tab, and table/pagination checks).

Changes

Feedback - Help Panel

Layer / File(s)	Summary
Test setup & timeouts playwright/feedback.spec.ts	New spec declares timeouts and a beforeEach that disables cookie prompts, navigates to /, and waits for the chrome header text ("Hi,") to confirm readiness.
Help panel navigation playwright/feedback.spec.ts	Opens the help panel, selects the "Feedback" subtab, and verifies the feedback home view is visible.
Form navigation & back behavior playwright/feedback.spec.ts	Opens "Share general feedback" form, exercises the "Back" button to return to feedback home, and reopens the form.
Submission & success assertions playwright/feedback.spec.ts	Fills the feedback textarea with randomized text, submits, and asserts success UI (including "thank you" and "Share more feedback") within the submission timeout. Does not verify downstream JIRA creation.

Support Cases - Help Panel

Layer / File(s)	Summary
Test setup & timeouts playwright/support-case.spec.ts	New spec defines SUPPORT_API_LOAD_TIMEOUT (~15s) and a beforeEach that disables cookie prompts, navigates to /, and waits for the chrome header ("Hi,").
Open My support cases view playwright/support-case.spec.ts	Opens help panel, selects the "My support cases" subtab, and waits up to timeout for either an empty-state element or the support cases table to render.
Empty-state / link visibility playwright/support-case.spec.ts	Asserts the "Open a support case" link is visible when the empty-state or table view appears.
External tab flow playwright/support-case.spec.ts	Clicks the "Open a support case" link, uses context.waitForEvent('page') to capture the new tab, asserts the new tab navigates to access.redhat.com (hostname check), then closes the tab.
Table & pagination assertions playwright/support-case.spec.ts	If the empty-state is visible, the test self-skips at runtime; otherwise it asserts the support cases table, pagination presence, and that at least one table row exists.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description covers what was migrated, why, and includes test details, but lacks the required JIRA link, screenshots section, and checklist completion.	Add JIRA link in format RHCLOUD-44391, include Screenshots section, and complete the checklist with test confirmations.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: migrating feedback tests from IQE to Playwright, with the relevant ticket reference.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@playwright/support-case.spec.ts`:
- Around line 56-61: The test assumes the "Open a support case" CTA is always
present but the SupportPanel renders that CTA only in empty-state; update the
spec to branch on which locator is visible: use the existing emptyState and
supportTable locators (emptyState, supportTable) to await visibility, then if
emptyState.isVisible() assert page.getByText(/open a support
case/i).toBeVisible(), else assert the CTA is not present or instead assert the
supportTable has expected rows; reference the SupportPanel component behavior
(src/components/HelpPanel/HelpPanelTabs/SupportPanel) when adding the
conditional assertion so tests are deterministic for accounts with open cases.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 40cb5586-615c-4875-8d96-8b92e55b1701

📥 Commits

Reviewing files that changed from the base of the PR and between 4100b96 and b9399eb.

📒 Files selected for processing (2)

• playwright/feedback.spec.ts
• playwright/support-case.spec.ts

[coderabbitai]

♻️ Duplicate comments (1)

playwright/support-case.spec.ts (1)

135-141: ⚠️ Potential issue | 🟠 Major | 🏗️ Heavy lift

Conditional skip hides the table scenario in CI.

When empty-state is shown, this test exits as skipped, so the “has open cases” path may never be validated. Prefer explicit fixture-gating (fixme with reason) or seeded data to avoid green builds with missing coverage.

Suggested adjustment

-    const emptyVisible = await emptyState.isVisible().catch(() => false);
-    if (emptyVisible) {
-      // User has no cases, skip this test
-      test.skip();
-      return;
-    }
+    const emptyVisible = await emptyState.isVisible();
+    test.fixme(
+      emptyVisible,
+      'Requires a seeded account with at least one open support case'
+    );

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@playwright/support-case.spec.ts` around lines 135 - 141, The current runtime
conditional that sets emptyVisible via emptyState.isVisible() and then calls
test.skip() hides the "has open cases" path in CI; remove this runtime skip
logic (the emptyVisible variable and the test.skip() call) and instead gate the
test explicitly using a fixture or Playwright's metadata helper (e.g., use
test.fixme(condition, 'reason') at the top of the test) or ensure the test runs
against seeded data so emptyState never appears; update references to emptyState
and remove the test.skip() branch so the test either uses a deterministic seeded
dataset or is marked with test.fixme with a clear reason.

🧹 Nitpick comments (1)

playwright/support-case.spec.ts (1)

43-57: ⚡ Quick win

Extract repeated “open support tab” flow into a helper.

The same panel-open/subtab-navigation sequence appears in three tests. Centralizing it will reduce drift and future flake fixes.

Refactor sketch

+async function openMySupportCasesTab(page: Page) {
+  await page.getByLabel('Toggle help panel').click();
+  await expect(page.locator('[data-ouia-component-id="help-panel-title"]')).toBeVisible();
+  await expect(page.locator('[data-ouia-component-id="help-panel-subtabs"]')).toBeVisible({
+    timeout: SUBTABS_LOAD_TIMEOUT,
+  });
+  await page.locator('[data-ouia-component-id="help-panel-subtab-support"]').click();
+}

-    await page.getByLabel('Toggle help panel').click();
-    ...
-    await supportTab.click();
+    await openMySupportCasesTab(page);

Also applies to: 70-84, 113-126

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@playwright/support-case.spec.ts` around lines 43 - 57, Extract the repeated
sequence that opens the help panel and navigates to the "My support cases"
subtab into a reusable helper (e.g., openSupportTab or gotoSupportSubtab) and
replace the duplicated blocks found around the current locator usage
(page.getByLabel('Toggle help panel'), help-panel-title, help-panel-subtabs,
help-panel-subtab-support) with calls to that helper; the helper should click
the help toggle, await visibility of
'[data-ouia-component-id="help-panel-title"]', await visibility of
'[data-ouia-component-id="help-panel-subtabs"]' with SUBTABS_LOAD_TIMEOUT, then
click '[data-ouia-component-id="help-panel-subtab-support"]', and update the
three test sites (the blocks at lines noted in the comment) to call this helper
instead of repeating the steps.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@playwright/support-case.spec.ts`:
- Around line 135-141: The current runtime conditional that sets emptyVisible
via emptyState.isVisible() and then calls test.skip() hides the "has open cases"
path in CI; remove this runtime skip logic (the emptyVisible variable and the
test.skip() call) and instead gate the test explicitly using a fixture or
Playwright's metadata helper (e.g., use test.fixme(condition, 'reason') at the
top of the test) or ensure the test runs against seeded data so emptyState never
appears; update references to emptyState and remove the test.skip() branch so
the test either uses a deterministic seeded dataset or is marked with test.fixme
with a clear reason.

---

Nitpick comments:
In `@playwright/support-case.spec.ts`:
- Around line 43-57: Extract the repeated sequence that opens the help panel and
navigates to the "My support cases" subtab into a reusable helper (e.g.,
openSupportTab or gotoSupportSubtab) and replace the duplicated blocks found
around the current locator usage (page.getByLabel('Toggle help panel'),
help-panel-title, help-panel-subtabs, help-panel-subtab-support) with calls to
that helper; the helper should click the help toggle, await visibility of
'[data-ouia-component-id="help-panel-title"]', await visibility of
'[data-ouia-component-id="help-panel-subtabs"]' with SUBTABS_LOAD_TIMEOUT, then
click '[data-ouia-component-id="help-panel-subtab-support"]', and update the
three test sites (the blocks at lines noted in the comment) to call this helper
instead of repeating the steps.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: db7bc7f6-378b-484f-a85c-3ae09c62dcba

📥 Commits

Reviewing files that changed from the base of the PR and between ac74ed6 and 82b079d.

📒 Files selected for processing (2)

• playwright/feedback.spec.ts
• playwright/support-case.spec.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• playwright/feedback.spec.ts