Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
[web] andualem added basic UI
* [web] Implement Article CRUD
* create the UI * [web] implement vuex state management * [web] implement CRUD functionalities * [web] add authentication and fix previous comments
* [web]: sample structure for the demo * [web]: folder rename to PascalCase * [web]: remove feature folder from store * [web]: fix a bug inside index page * [web]: fix deployment bug
* [web][yohans] added some basic ui and simple database mocking array * [web][yohans] added some state for the blogs
* [web]: sample structure for the demo * [web]: remove feature folder from store * [web]: file rename issue with git solved * [WEB]: fix deploy error
| commit('newBlog',response.data); | ||
| }, | ||
| async deleteBlog({commit},id){ | ||
| await axios.delete(`https://blog-app-backend.onrender.com/api/articles/${id}`); |
There was a problem hiding this comment.
No need for an absolute path. Base URL is already set.
| methods:{ | ||
| toggleAddBlog(){ | ||
| this.showAddBlog = !this.showAddBlog | ||
| }, | ||
| } | ||
|
|
There was a problem hiding this comment.
Please run npm run lintfix before committing.
There was a problem hiding this comment.
This will fix indentation and other style problems
| const response = await axios.get( | ||
| `https://blog-app-backend.onrender.com/api/articles/${this.$route.params.id}` | ||
| ) |
There was a problem hiding this comment.
All reading and writing data should be handled by vuex.
| title: '', | ||
| content: '' |
There was a problem hiding this comment.
Instead, a better approach is to declare blog object
blog: {
title: '',
content: ''
}
| const newBlog = { | ||
| title: this.title, | ||
| content: this.content | ||
| } |
There was a problem hiding this comment.
This is unnecessary if the above comment is addressed.
| title: this.title, | ||
| content: this.content | ||
| } | ||
| this.addBlog(newBlog) |
There was a problem hiding this comment.
this.addBlog(this.blog)
danielgitk
left a comment
danielgitk
left a comment
There was a problem hiding this comment.
Do we need to add all the react files to the commit?
TripleThreads
left a comment
TripleThreads
left a comment
There was a problem hiding this comment.
This PR has changes from another project (React web project). Please make sure your changes are limited to your scope.
|
8 participants
I have done a basic UI and fetched the data from backend. I am working on posting a new blog and updating it.