feat(Android): allow setting `foregroundServiceType` (+ improve stability) by GaelCO · Pull Request #265 · Rapsssito/react-native-background-actions

GaelCO · 2026-03-23T10:23:10Z

-> use ServiceCompat
-> allow setting foregroundServiceType
-> Improve stability for android 12+
-> manage service onTimeOut to stop service on android 14+

…the documentation

GaelCO · 2026-03-25T10:10:51Z

My PR is intended to address the following issues:

GaelCO · 2026-03-25T10:11:57Z

Hi @Rapsssito ,
Is this project still maintained? I opened a PR to improve react-native-background-actions and would be happy to help maintain if needed

Rapsssito · 2026-03-25T11:58:42Z

lib/types/index.d.ts

Please, remove the changes to .d.ts files, these files are autogenerated on release based on JSDocs.

Rapsssito · 2026-03-25T11:59:54Z

Thanks @GaelCO for the PR! Please, see my comments.

Copilot

Pull request overview

This PR aims to improve Android foreground-service stability (Android 12+) and add support for configuring the foreground service type from JS, with updated documentation and TypeScript types.

Changes:

Add foregroundServiceType to JS options normalization and TypeScript declarations.
Switch Android service start to ContextCompat.startForegroundService and ServiceCompat.startForeground, plus handle null intents and Android 14+ onTimeout.
Document the new option and required Android manifest/permission setup.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/index.js	Adds `foregroundServiceType` to the JS options contract and passes it through normalization.
lib/types/index.d.ts	Extends TS types to include `foregroundServiceType` in public API typings.
android/src/main/java/com/asterinet/react/bgactions/RNBackgroundActionsTask.java	Uses `ServiceCompat.startForeground`, handles null intents, and stops service on `onTimeout`.
android/src/main/java/com/asterinet/react/bgactions/BackgroundTaskOptions.java	Maps JS `foregroundServiceType` string to Android `ServiceInfo.FOREGROUND_SERVICE_TYPE_*` constants.
android/src/main/java/com/asterinet/react/bgactions/BackgroundActionsModule.java	Starts service via `ContextCompat.startForegroundService` and clears intent on stop.
README.md	Documents `foregroundServiceType` and updates the options table.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

README.md

android/src/main/java/com/asterinet/react/bgactions/BackgroundTaskOptions.java

src/index.js

GaelCO · 2026-03-25T13:19:09Z

Hi, I reverted changes in d.ts .
Would you like me to incorporate Copilot’s suggestions?

GaelCO · 2026-03-26T08:34:55Z

Hi @Rapsssito,
I modified the signature to allow multiple foregroundServiceType values. I considered allowing both a string and an Array, but I thought that would be less clear, so I only allowed Array.
I took Copilot’s feedback into account, but since I made quite a few changes, it might be worth running it through again.

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

android/src/main/java/com/asterinet/react/bgactions/BackgroundTaskOptions.java

README.md

android/src/main/java/com/asterinet/react/bgactions/RNBackgroundActionsTask.java

GaelCO · 2026-03-30T06:55:25Z

The co-pilot requests have been processed

Copilot

Pull request overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

android/src/main/java/com/asterinet/react/bgactions/RNBackgroundActionsTask.java:92

onStartCommand throws when intent.getExtras() is null, which can crash the process and undermines the stated stability improvements (e.g., service restarts or mis-starts). Consider handling extras == null like intent == null: stopSelf() and return START_NOT_STICKY (or otherwise fail gracefully) instead of throwing.

        final Bundle extras = intent.getExtras();
        if (extras == null) {
            throw new IllegalArgumentException("Extras cannot be null");
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-30T19:47:51Z

README.md

+| Value | Android API | `<uses-permission>` required |
+| --- |-------------| --- |
+| `"dataSync"` *(default)* | 29 (Q)      | `android.permission.FOREGROUND_SERVICE_DATA_SYNC` |
+| `"mediaPlayback"` | 29 (Q)      | `android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK` |
+| `"phoneCall"` | 29 (Q)      | `android.permission.FOREGROUND_SERVICE_PHONE_CALL` |


Docs say "dataSync" is the default foreground service type, but the implementation returns 0 when foregroundServiceType is omitted (no default is applied). Either implement the stated default (e.g., treat undefined/empty as dataSync on API 29+) or adjust the documentation to avoid implying a default that isn’t enforced.

Copilot · 2026-03-30T19:47:52Z

android/src/main/java/com/asterinet/react/bgactions/BackgroundTaskOptions.java

+        for (final String type : types) {
+            final int flag = typeToForegroundServiceFlag(type);
+            if (flag != 0) {
+                result |= flag;
+            }
+        }
+        return result;
+    }
+
+    private int typeToForegroundServiceFlag(@NonNull final String type) {
+        switch (type) {
+            case "dataSync":


getForegroundServiceType() iterates types and passes each entry to typeToForegroundServiceFlag(type). If the JS array contains null (or a non-string that ends up as null in the Bundle), switch (type) will throw a NullPointerException and crash the service. Consider filtering/validating entries (e.g., skip null/empty values) before the switch so invalid input can’t crash the app process.

gcd added 4 commits March 23, 2026 10:19

fix crash on android 12+

5e05d48

fix crash when service relaunch without intent

14192cd

stop service when onTimeout happened

fedbb41

Use ServiceCompat + allow setting the foregroundServiceType + update …

2f35ac6

…the documentation

GaelCO changed the title ~~Improve stability~~ Improve stability + allow pass foregroundServiceType Mar 25, 2026

GaelCO changed the title ~~Improve stability + allow pass foregroundServiceType~~ Improve stability + allow setting foregroundServiceType Mar 25, 2026

gcd added 2 commits March 25, 2026 10:53

update rn code to add foregroundServiceType

5747dab

fix bad comma

85d9f7d

Rapsssito reviewed Mar 25, 2026

View reviewed changes

Rapsssito requested a review from Copilot March 25, 2026 12:00

Copilot started reviewing on behalf of Rapsssito March 25, 2026 12:01 View session

Rapsssito changed the title ~~Improve stability + allow setting foregroundServiceType~~ feat(Android): allow setting foregroundServiceType (+ improve stability) Mar 25, 2026

Copilot AI reviewed Mar 25, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

android/src/main/java/com/asterinet/react/bgactions/BackgroundTaskOptions.java Show resolved Hide resolved

src/index.js Show resolved Hide resolved

revert change in index.d.ts

58a2f1b

gcd added 2 commits March 26, 2026 09:16

allow multiple foregroundServiceType

2b1bd13

don't add type if it not managed by the android version

dfe9f1c

gcd added 2 commits March 26, 2026 09:35

updated test

c40bcb7

update test to pass checkjs

458e8e9

Rapsssito requested a review from Copilot March 27, 2026 20:45

Copilot started reviewing on behalf of Rapsssito March 27, 2026 20:45 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

android/src/main/java/com/asterinet/react/bgactions/BackgroundTaskOptions.java Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

android/src/main/java/com/asterinet/react/bgactions/RNBackgroundActionsTask.java Outdated Show resolved Hide resolved

gcd added 2 commits March 30, 2026 08:50

specify the DATA_SYNC case + update README.md

66e2136

replace Exception by RuntimeException

1dc3ba3

Rapsssito requested a review from Copilot March 30, 2026 19:42

Copilot started reviewing on behalf of Rapsssito March 30, 2026 19:42 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Uh oh!

Conversation

GaelCO commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaelCO commented Mar 25, 2026

Uh oh!

GaelCO commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rapsssito Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Rapsssito commented Mar 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GaelCO commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaelCO commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GaelCO commented Mar 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GaelCO commented Mar 23, 2026 •

edited

Loading

GaelCO commented Mar 25, 2026 •

edited

Loading

GaelCO commented Mar 25, 2026 •

edited

Loading