Open
Conversation
m-abrosimov
reviewed
Apr 18, 2021
| class Example{ | ||
| @validDecorator | ||
| public email: string = ""; | ||
| } |
| } | ||
| /**Класс описывает TextBox контрол */ | ||
| class TextBox extends Control<string> { | ||
| protected val: string | undefined |
| public name: string = ""; | ||
|
|
||
| protected value: T; | ||
| protected value: T | undefined; |
There was a problem hiding this comment.
Зачем используешь объединение типов?
|
|
||
| /**Класс описывает SelectBox контрол */ | ||
| class SelectBox extends Control<SelectItem> { | ||
| protected val: SelectItem | undefined; |
There was a problem hiding this comment.
зачем поле в котором хранится значение ?
|
|
||
| const x = undefined; | ||
| const x = { "m": "Ы" }; | ||
|
|
| class DecorateRu extends Calculator { | ||
| public exec(): string{ | ||
| return `результат сложения ${this.a} + ${this.b} = ${super.exec()}`} | ||
| } |
There was a problem hiding this comment.
Это не патерн декоратор
https://refactoring.guru/ru/design-patterns/decorator/typescript/example
| } | ||
| if (!(typeInstance instanceof Control)){ | ||
| throw new Error("Invalid type"); | ||
|
|
There was a problem hiding this comment.
Нет регистрации типа и созданного объекта. Работать не будет.
|
пока что 6 балов |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.