Work on powerpc/beatnik/if_mve network driver (epics codeathon 2021)#4
Open
till-s wants to merge 7 commits intoRTEMS:5-freebsd-12from
Open
Conversation
First stab at mv643xx; port almost complete (mii stuff missing) and compiles -- no tests yet!
was delayed by waf not printing compiler warnings by default! Three little typos cost me almost a day: - missing 'return 0;' at the end of mve_attach() - two bad pointers (wrong type) used All of these would have been found within minutes had the warnings not been disabled :-(
The recursive lock takes care of this...
Testing (TCP with larger amounts of data while MVETH_TESTING was defined which reduces the ring sizes to very small numbers) revealed that the BSD stack honours the 'sendqlen' and never hands us chains exceeding the ring size.
…r statistics The 'legal' access by means of a special ioctl() is way too cumbersome when you need to do quick diagnosis.
avoid using struct members directly.
Member
|
Is this a PCI bus device? |
Author
|
The ethernet adapter is part of the system controller and accessible directly (w/o going through PCI). |
Member
|
Maybe I have the wrong board. Do you have a link to the board's datasheet? The beatnik I have looked at has an octet Marvel NIC and there are are 8 marvel devices appearing in the PCI probes. The e1000 is on a secondary PCI bus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request adds a nexus ethernet driver for the Marvell mv643xx chip which is present on the MVME6100 board (beatnik BSP). Note that the patch requires a companion patch to the RTEMS BSP.