Users/jamessiddeley amd/roofline add lds ai plot point#6483
Draft
jamessiddeley-amd wants to merge 3 commits into
Draft
Users/jamessiddeley amd/roofline add lds ai plot point#6483jamessiddeley-amd wants to merge 3 commits into
jamessiddeley-amd wants to merge 3 commits into
Conversation
4205101 to
4c670b9
Compare
Resolve gfx115x config-management rename conflicts and keep the shared RDNA 3.5 config path validating against the gfx11 template. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add LDS arithmetic intensity roofline plot points and make roofline plot colors easier to view by aligning cache level marker colors with their corresponding ceiling lines
Technical Details
SQ_LDS_IDX_ACTIVE/SQ_LDS_BANK_CONFLICTvalues.JIRA ID
ROCM-24893
Test Plan
vcopyandoccupancyworkloads on MI350Test Result
pytest tests/test_roofline_calc_ai_analyze.py -qpassedROCPROF=rocprofv3CSV output has one row per dispatch/counter for tested workloadsrocprof-compute analyze -VVV -p workloads/occupancy_lds_bw/MI350/ -b 4empirRoof_gpu-0_FP32_lds_bw_FP32.html
Submission Checklist