[WIP][rocjitsu] Add CI workflow (pip rocm-sdk-core approach)#6479
Draft
newling wants to merge 1 commit into
Draft
[WIP][rocjitsu] Add CI workflow (pip rocm-sdk-core approach)#6479newling wants to merge 1 commit into
newling wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
github actions
newling
added a commit
to newling/rocm-systems
that referenced
this pull request
May 27, 2026
Before this PR, the TheRock CI builds rocjitsu (as part of THEROCK_ENABLE_EMULATION) but does not run its tests — rocjitsu is not in repos-config.json. The only rocjitsu-specific CI is pre-commit formatting. After this PR, every PR touching emulation/rocjitsu/ gets a dedicated job that builds rocjitsu and runs its full ctest suite (~450 tests), including HIP integration tests (memcpy, vector_add, matmul). No GPU hardware needed — tests run on the built-in CPU emulator. ROCm installed from the AMD apt repo for hipcc and device libraries. RocminfoTest excluded (requires /dev/kfd, unavailable on CI). Related: ROCm#6479 (alternative using pip rocm-sdk-core)
newling
force-pushed
the
rocjitsu-ci-pip
branch
3 times, most recently
from
8cdc7b4 to
fe5a321
Compare
newling
force-pushed
the
rocjitsu-ci-pip
branch
3 times, most recently
from
0184d9e to
13e3c7d
Compare
Before this PR, the TheRock CI builds rocjitsu (as part of THEROCK_ENABLE_EMULATION) but does not run its tests — rocjitsu is not in repos-config.json. The only rocjitsu-specific CI is pre-commit formatting. After this PR, every PR touching emulation/rocjitsu/ gets a dedicated job that builds rocjitsu and runs its full ctest suite (~450 tests), including HIP integration tests (memcpy, vector_add, matmul). No GPU hardware needed — tests run on the built-in CPU emulator. ROCm SDK installed via pip from TheRock. Decouple HIP test cmake gate from HSA_RUNTIME64 — the HIP tests only need hipcc for compilation and LD_PRELOAD at runtime. Prefer ROCM_PATH from env over deriving from compiler location in rj_add_device_kernel, for pip SDK compatibility. RocminfoTest excluded (requires /dev/kfd, unavailable on CI). Related PRs: - ROCm#6448: alternative approach using ROCm apt packages - ROCm#6441: earlier pip attempt (closed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Alternative to #6448 (apt approach), using
pip install rocm-sdk-coreinstead ofapt install rocm-hip-sdk. Addresses review feedback from #6448.See also #6441 (earlier pip attempt, closed).
Changes from #6448
actions/checkoutto SHA per best practice-DCMAKE_CXX_COMPILERinstead of env varsTest plan