[stinkytofu] add remove nop pass#7748
Merged
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
shared: stinkytofu
labels
Contributor
Author
|
FFM tox and stinkytofu test passed |
hcman2
force-pushed
the
users/hcman2/rm_nop_pass
branch
2 times, most recently
from
73299f1 to
284c84f
Compare
KKyang
approved these changes
May 26, 2026
hcman2
force-pushed
the
users/hcman2/rm_nop_pass
branch
from
284c84f to
302fc7b
Compare
cycheng
approved these changes
May 26, 2026
hcman2
force-pushed
the
users/hcman2/rm_nop_pass
branch
from
302fc7b to
36fa1f1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7748 +/- ##
========================================
Coverage 61.94% 61.94%
========================================
Files 2084 2084
Lines 357211 357211
Branches 53982 53982
========================================
Hits 221249 221249
Misses 117157 117157
Partials 18805 18805
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
hcman2
force-pushed
the
users/hcman2/rm_nop_pass
branch
from
36fa1f1 to
d572617
Compare
yenong-amd
pushed a commit
that referenced
this pull request
May 28, 2026
## Motivation [AIHPBLAS-1405] Add a pass to remove nop in loop. In loop is the first step. We should expand this feature to all of the code further. ## Technical Details <!-- Explain the changes along with any relevant GitHub links. --> ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result stinkytofu test passed ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. [AIHPBLAS-1405]: https://amd-hub.atlassian.net/browse/AIHPBLAS-1405?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AIHPBLAS-1405
Add a pass to remove nop in loop.
In loop is the first step. We should expand this feature to all of the code further.
Technical Details
Test Plan
Test Result
stinkytofu test passed
Submission Checklist