Fix TDM GSU offset for all MX datatype and transpose cases#7401
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7401 +/- ##
========================================
Coverage 61.87% 61.87%
========================================
Files 2086 2086
Lines 357038 357035 -3
Branches 53806 53806
========================================
Hits 220892 220892
+ Misses 117348 117345 -3
Partials 18798 18798
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates TDM address calculation to correctly account for GlobalSplitU (GSU) offsets across MX datatypes and transpose-related cases, and expands MX test coverage for GSU>1.
Changes:
- Replace hardcoded TDM stride selection (
strideRef(tc, 3)) with a dynamically derived “unroll” index. - Add GSU-based address offsetting in TDM (including MX-specific scaling).
- Expand MX YAML test matrices to include
GlobalSplitU: [1,2,4,8].
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| projects/hipblaslt/tensilelite/Tensile/Tests/common/gemm/gfx12/mxf8f4ss_gfx1250.yaml | Expands MX test coverage for additional GSU values. |
| projects/hipblaslt/tensilelite/Tensile/Tests/common/gemm/gfx12/mxf8_gfx1250.yaml | Expands multiple benchmark problem blocks to cover GSU=[2,4,8]. |
| projects/hipblaslt/tensilelite/Tensile/Components/TensorDataMover.py | Computes dynamic unroll stride and applies GSU offset in TDM start-address logic (MX + non-MX). |
| projects/hipblaslt/tensilelite/Tensile/Components/GSU.py | Minor string-formatting modernization for MX size SGPR reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aazz44ss
approved these changes
May 14, 2026
ssuyuanchang
force-pushed
the
users/joschang/tdm_gsu_offset
branch
2 times, most recently
from
32ca18e to
ab11deb
Compare
ssuyuanchang
force-pushed
the
users/joschang/tdm_gsu_offset
branch
2 times, most recently
from
9b65b35 to
1b67e1a
Compare
- Replaced hardcoded strideRef(tc, 3) with dynamic unroll index - Supported GSU for MX datatype - Added GSU=[2,4,8] coverage to MX test yamls
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TDM support GSU MB
Technical Details
Add GSU offset in TDM mode
Test Plan
hipblast-test and test yaml passed
Test Result
hipblast-test and test yaml passed
Submission Checklist