Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2306 +/- ##
===========================================
- Coverage 79.50% 78.89% -0.62%
===========================================
Files 100 123 +23
Lines 31016 40444 +9428
Branches 4819 6638 +1819
===========================================
+ Hits 24659 31905 +7246
- Misses 4245 5634 +1389
- Partials 2112 2905 +793
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
umangyadav
approved these changes
Mar 23, 2026
c67cd22 to
9212ebf
Compare
9212ebf to
61c06ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove unused operations.
Technical Details
I suspect that this operation is never used for the following reasons:
There is no lowering from migraphx.flatten to the Tosa pipeline.
There is no reference of
FlattenOpinMIGraphXToTosa.cpp.I ran
git log --oneline | grep flattenand nothing significant seems to show up.It was introduced in this commit - the inception of MIGraphX dialect and it doesn't have any testcase.
Test Plan
N/A
Test Result
N/A
Submission Checklist