Skip to content

fix: use compiled spdlog with hidden visibility to prevent symbol collision #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhchouuu merged 1 commit into from
May 21, 2026
Merged

fix: use compiled spdlog with hidden visibility to prevent symbol collision #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,18 @@ set(SPDLOG_BUILD_BENCH
CACHE BOOL "" FORCE)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
add_subdirectory(3rdparty/spdlog)
# Hide spdlog symbols from other libraries to avoid symbol conflicts
target_compile_options(spdlog PRIVATE -fvisibility=hidden
-fvisibility-inlines-hidden)
# Hide spdlog symbols to avoid cross-library symbol collisions. Both rocroller
# (via hipblaslt/TE) and MORI statically link spdlog; if both export spdlog
# symbols, MORI's spdlog calls can be interposed by rocroller's copy, causing
# heap corruption (free(): invalid size). Using the compiled spdlog library (not
# header-only) with hidden visibility ensures spdlog symbols stay internal to
# MORI's .so files.
set_target_properties(spdlog PROPERTIES CXX_VISIBILITY_PRESET hidden
VISIBILITY_INLINES_HIDDEN ON)

add_library(mori_logging INTERFACE)
target_include_directories(mori_logging INTERFACE include)
target_link_libraries(mori_logging INTERFACE spdlog::spdlog_header_only)
target_link_libraries(mori_logging INTERFACE spdlog::spdlog)

if(ENABLE_PROFILER)
find_package(
Expand Down
Loading