[Feature] Global image pull secrets injection (#1196)#476
Merged
sajmera-pensando merged 1 commit intoROCm:mainfrom Mar 19, 2026
Merged
[Feature] Global image pull secrets injection (#1196)#476sajmera-pensando merged 1 commit intoROCm:mainfrom
sajmera-pensando merged 1 commit intoROCm:mainfrom
Conversation
Signed-off-by: yansun1996 <Yan.Sun3@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add Global Image Pull Secrets Support
Summary
Adds
global.imagePullSecretsfield to configure image pull secrets once and automatically apply them across all GPU operator components. Simplifies deployment in air-gapped environments and with private registries.Motivation
Previously, users needed to configure image pull secrets individually for 10+ components (controller, hooks, DeviceConfig components, KMM, NFD). This was verbose, error-prone, and difficult to manage during secret rotation.
Changes
CRD
spec.commonConfig.imageRegistrySecretsfield (array type)Controller
Helm Chart
global.imagePullSecretsfield invalues.yamlKMM Subchart
Hack Templates
hack/k8s-patch/(9 files)Documentation & Testing
TestGlobalImagePullSecretsE2E testUsage
Basic:
helm install amd-gpu-operator . \ --set global.imagePullSecrets[0].name=my-secretTechnical Details
Test Plan
Added 2 new e2e test cases to verify that the global image pull secrets could be forwarded correctly.
Test Result
Submission Checklist