feat: add HostNetwork field to DevicePlugin and MetricsExporter#465
Merged
sajmera-pensando merged 2 commits intoROCm:mainfrom Mar 13, 2026
Conversation
yansun1996
force-pushed
the
feature/host-network-device-plugin-metrics-exporter
branch
2 times, most recently
from
aa29c7c to
8ea40d0
Compare
uMetalooper
commented
Mar 11, 2026
yansun1996
force-pushed
the
feature/host-network-device-plugin-metrics-exporter
branch
from
f7ca301 to
f4cd475
Compare
Add optional HostNetwork field to DevicePluginSpec and MetricsExporterSpec in the DeviceConfig CRD, allowing users to configure host network namespace for the respective DaemonSet pods. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: yansun1996 <Yan.Sun3@amd.com>
yansun1996
force-pushed
the
feature/host-network-device-plugin-metrics-exporter
branch
from
f4cd475 to
ec2fc0d
Compare
yansun1996
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Uber, we use host networking for our setup instead of relying on k8s cluster networking. So it would be great to allow daemonsets to communicate via host network namespace.
HostNetwork *boolfield toDevicePluginSpecin the DeviceConfig CRDHostNetwork *boolfield toMetricsExporterSpecin the DeviceConfig CRDHostNetworkininternal/plugin/plugin.goto setHostNetworkon the device plugin DaemonSet pod specHostNetworkininternal/metricsexporter/metricsexporter.goto setHostNetworkon the metrics exporter DaemonSet pod specTest plan
hostNetwork: truewhen set in DeviceConfig spechostNetwork: truewhen set in DeviceConfig spechostNetworkset) is unchanged🤖 Generated with Claude Code