Add TODO for truthiness-check bug in latency-by-streams sheet#132
Draft
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_4from
Draft
Add TODO for truthiness-check bug in latency-by-streams sheet#132Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_4from
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_4from
Conversation
Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add TODO in excel report generation based on review feedback
Add TODO for truthiness-check bug in latency-by-streams sheet
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_build_latency_by_streams_sheetuses truthiness checks (if b_val,if b_val and t_val) that silently drop legitimate0.0P99 values and skip Δ% computation for them.Changes
hwqueue_excel.pyto replace truthiness checks withis not Noneguards, ensuring zero P99 measurements are preserved and Δ% is computed correctly.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.