Validate SweepData.from_dict() results entries are dicts, raise HWQueueLoaderError#124
Closed
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_1from
Closed
Validate SweepData.from_dict() results entries are dicts, raise HWQueueLoaderError#124Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_1from
SweepData.from_dict() results entries are dicts, raise HWQueueLoaderError#124Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_1from
Conversation
…ueLoaderError Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update json loader for configuration changes based on review feedback
Validate Mar 6, 2026
SweepData.from_dict() results entries are dicts, raise HWQueueLoaderError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SweepData.from_dict()iterated overdata["results"]assuming all entries were dicts. Non-dict entries (strings, ints, lists,None) causedAttributeErrorfrom.get()to escape rather than a meaningfulHWQueueLoaderError.Changes
hwqueue_loader.py— Replace the list comprehension inSweepData.from_dict()with an explicit loop that validates each entry withisinstance(r, dict), raisingHWQueueLoaderErrorwith the entry index and actual type on failure:tests/test_hwqueue_loader.py(new) — 11 tests covering: valid entries, empty/missingresults, non-dict entry types (str,int,list,None), correct index in error message, noAttributeErrorescaping, and integration throughHWQueueLoader.load_sweep()/load_auto().💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.