Fix SweepSummary status inference never running due to "good" default#122
Draft
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_8from
Draft
Fix SweepSummary status inference never running due to "good" default#122Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_8from
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_8from
Conversation
…ference always runs Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update generated HTML summary based on feedback
Fix SweepSummary status inference never running due to "good" default
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SweepSummary.__post_init__()was intended to inferscaling_status/latency_statusfrom verdict text when not explicitly provided. However, both fields defaulted to"good", which is itself a valid status — so thenot in valid_statusesguard was alwaysFalseand inference never ran.get_overall_status()consequently always returned"good".Changes
SweepSummary: Changescaling_statusandlatency_statusdefaults from"good"toNone(Optional[str]), so__post_init__inference always runs unless the caller explicitly passes a valid status string.__post_init__docstring: Updated to reflect the corrected semantics — infer unless overridden.Explicit caller overrides (
scaling_status="warning") are still respected since"warning"passes thenot in valid_statusescheck.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.