Skip to content

Fix SweepSummary status inference never running due to "good" default#122

Draft
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_8from
copilot/sub-pr-105-again
Draft

Fix SweepSummary status inference never running due to "good" default#122
Copilot wants to merge 2 commits intoprosenj_cli_hq_eval_report_phase_8from
copilot/sub-pr-105-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 6, 2026

SweepSummary.__post_init__() was intended to infer scaling_status/latency_status from verdict text when not explicitly provided. However, both fields defaulted to "good", which is itself a valid status — so the not in valid_statuses guard was always False and inference never ran. get_overall_status() consequently always returned "good".

Changes

  • SweepSummary: Change scaling_status and latency_status defaults from "good" to None (Optional[str]), so __post_init__ inference always runs unless the caller explicitly passes a valid status string.
  • __post_init__ docstring: Updated to reflect the corrected semantics — infer unless overridden.
# Before: "good" is in valid_statuses → inference branches never execute
scaling_status: str = "good"
latency_status: str = "good"

# After: None is not in valid_statuses → inference always runs
scaling_status: Optional[str] = None
latency_status: Optional[str] = None

Explicit caller overrides (scaling_status="warning") are still respected since "warning" passes the not in valid_statuses check.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ference always runs

Co-authored-by: prosenjitdhole <239307697+prosenjitdhole@users.noreply.github.com>
Copilot AI changed the title [WIP] Update generated HTML summary based on feedback Fix SweepSummary status inference never running due to "good" default Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants