Adding attention bias input to Multi Head Attention parser#4680
Open
urpetkov-amd wants to merge 12 commits intodevelopfrom
Open
Adding attention bias input to Multi Head Attention parser#4680urpetkov-amd wants to merge 12 commits intodevelopfrom
urpetkov-amd wants to merge 12 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4680 +/- ##
===========================================
+ Coverage 92.27% 92.28% +0.01%
===========================================
Files 578 578
Lines 28541 28561 +20
===========================================
+ Hits 26335 26355 +20
Misses 2206 2206
🚀 New features to boost your workflow:
|
TedThemistokleous
requested changes
Mar 20, 2026
Collaborator
TedThemistokleous
left a comment
There was a problem hiding this comment.
Everything looks good here. Just add a test for verify something simple just take the gold values from a working test and then bias the kv inputs or generate a verify case for the added bias to ensure we don't get regressions if something changes. Otherwise looks good.
Collaborator
Author
|
@TedThemistokleous Tests have been added. |
TedThemistokleous
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR has been created as separate PR desired from this PR: #4637
Adding attention bias as new input for MultiHeadAttention parser in order to support some models.
Technical Details
Added attention bias in parse_multi_head_attention.cpp
Added tests covering bias and attention bias changes
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable