Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates related to environment configuration, logging improvements, and dependency upgrades. The main focus is on improving the handling of environment-specific URLs, increasing logging visibility for email-related actions, and updating the Spring Boot version.
Environment configuration and URL handling:
MailgunEmailService#getBaseUrlto correctly construct the base URL for the "staging" environment, ensuring that the domain is adjusted for staging deployments.TARGET_ENVvariable in theterraform-stg/main.tfKubernetes deployment from "production" to "staging", aligning the infrastructure configuration with the intended environment.Logging improvements:
MailgunEmailServiceto output the generated confirmation and password reset links, aiding in debugging and monitoring email operations. [1] [2]MailgunEmailServiceto use the class name string, ensuring consistency and clarity in log outputs.Dependency updates:
server/pom.xmlto incorporate the latest fixes and improvements.