Chip of the Old Battery#24
Merged
ActuallyTaylor merged 6 commits intofeature/mjmagee991/v4-bringupfrom Apr 2, 2026
Merged
Conversation
Still needs a lot more work, but it turns out writing good docs is difficult. I will continue to work on this throughout the semester. Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
I finished up the documentation for checking the polarity. There is a paragraph style explanation with more detail and a bulleted list that is easier to follow. I aslo added a new command into the bq_interface that will read the current and convert it for you. This removes the need to use a direct memory read and then convert the hexadecimal. Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
Signed-off-by: Taylor Lineman <git@actuallytaylor.com>
…lor/v4-validation-docs
aclowmclaughlin
approved these changes
Mar 6, 2026
Contributor
aclowmclaughlin
left a comment
aclowmclaughlin
left a comment
There was a problem hiding this comment.
Looks good. Noticed some references to BMS 3.0 and BMS 4.0, should probably standardize which one? unless it makes sense.
Member
Author
I checked out the references to BMS 3.0 in the updated docs and they seem to be accurate. The mention of BMS v3 for UART is specific because it is mentioning the introduction of UART. |
…lor/v4-validation-docs
tmb5932
approved these changes
Mar 20, 2026
ChongOscar
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes BMS v4.0 Hardware Bringup.
bq_interfacetarget.