Recipes calling relax/static jobs now return a dict#3158
Open
vineetbansal wants to merge 1 commit intomainfrom
Open
Recipes calling relax/static jobs now return a dict#3158vineetbansal wants to merge 1 commit intomainfrom
vineetbansal wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3158 +/- ##
=======================================
Coverage 97.64% 97.64%
=======================================
Files 98 98
Lines 4282 4295 +13
=======================================
+ Hits 4181 4194 +13
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@claude review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses some changes in
jobflowReplacebehavior to test if the idea ofsubflows returning a dict{"relax": <list-of-jobs>, "static": <list-of-jobs>}might work. The upstream changes are from a fork ofjobflowand a custom branch, till we're satisfied with the behavior, at which point we can open a PR onjobflow.