Fix pyproject.toml build-system configuration#100
Open
gotmax23 wants to merge 2 commits intoQuantco:mainfrom
Open
Fix pyproject.toml build-system configuration#100gotmax23 wants to merge 2 commits intoQuantco:mainfrom
gotmax23 wants to merge 2 commits intoQuantco:mainfrom
Conversation
setuptools is an implicit default, but projects are supposed to explicitly set the build-backend. pip does not seem affected by this omission, but at least [pyproject-rpm-macros] used in Fedora Linux is more strict in this regard and requires both options to be specified when the `[build-system]` table exists. [pyproject-rpm-macros]: https://src.fedoraproject.org/rpms/pyproject-rpm-macros/
Newer setuptools versions don't use the wheel package anymore. Older setuptools versions don't need this either, as PEP 517 `get_requires_for_build_wheel()` would always include `wheel` when it was necessary.
|
Thanks! I was looking at the downstream package review for Fedora, and I was going to suggest offering the See also https://discuss.python.org/t/do-we-want-to-keep-the-build-system-default-for-pyproject-toml/104759/26, which supports the idea that it’s good not to rely on the setuptools default for the build system, especially for a project without a “legacy” |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for more info.
Checklist
CHANGELOG.rstentry